Gamma calculation with combined curve #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yukiiwashita
commented
May 4, 2018
•
yukiiwashita
commented
- Split a curve into underlying curves in the curve gamma calculator
jodastephen
approved these changes
May 8, 2018
| result = result.combinedWith(gammaSingle); | ||
| } else if (curve.split().size() > 1) { |
There was a problem hiding this comment.
Can this just be a foreach loop of the split curves? Won't that handle the non-combined case?
There was a problem hiding this comment.
The underlying curves should be checked only when a sensitivity object is not found, because CurrencyParameterSensitivity is not necessarily split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.